Skip to content

chore: Upgrade Go version to 1.23 #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: Upgrade Go version to 1.23 #2526

wants to merge 1 commit into from

Conversation

tenzen-y
Copy link
Member

What this PR does / why we need it:
This is blocking #2525

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@tenzen-y
chore: Upgrade Go version to 1.23
dd34092 
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from tenzen-y. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Electronic-Waste
Copy link
Member

Thanks for this @tenzen-y! Actually, I've upgraded both go and kubernetes version in #2521. I would appreciate it if you could take a look:)

Electronic-Waste
Electronic-Waste reviewed Mar 19, 2025
View reviewed changes
Copy link
Member

@Electronic-Waste Electronic-Waste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tenzen-y Basically LGTM. Feel free to merge it after the doc is updated!

I'll rebase my PR so as not to block the 0.18.0 release.

/assign @andreyvelich

go.mod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the go version in the contributing doc?

katib/CONTRIBUTING.md

Line 14 in 1f76bb3

- [Go](https://golang.org/) (1.22 or later)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Electronic-Waste Electronic-Waste Electronic-Waste left review comments

@anencore94 anencore94 Awaiting requested review from anencore94

Assignees

@andreyvelich andreyvelich

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tenzen-y @Electronic-Waste @andreyvelich